Fixed #3298 population of audit columns on Sales and Discounts after …

…saving
craftcms · Oct 13, 2023 · 02ed12a · 02ed12a
1 parent 6497a44
commit 02ed12a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - Fixed a bug where the delete button would be shown for users that do not have permission to delete on the Product edit page. ([#3285](https://github.com/craftcms/commerce/issues/3285))
 - Fixed a bug where deleted shipping categories were still available for selection. ([#3272](https://github.com/craftcms/commerce/issues/3272))
 - Fixed an error that could occur when rendering a PDF. ([#2633](https://github.com/craftcms/commerce/issues/2633))
+- Fixed a bug where Sale’s and Discount’s date audit columns weren’t populated after saving. ([#3298](https://github.com/craftcms/commerce/issues/3298))
 
 ## 4.3.0 - 2023-09-13
 

diff --git a/src/services/Discounts.php b/src/services/Discounts.php
@@ -693,6 +693,12 @@ public function saveDiscount(Discount $model, bool $runValidation = true): bool
             $record = new DiscountRecord();
         }
 
+        // Make sure the datetime attributes are populated before firing the event
+        if (!$isNew) {
+            $model->dateCreated = DateTimeHelper::toDateTime($record->dateCreated);
+            $model->dateUpdated = DateTimeHelper::toDateTime($record->dateUpdated);
+        }
+
         // Raise the beforeSaveDiscount event
         if ($this->hasEventHandlers(self::EVENT_BEFORE_SAVE_DISCOUNT)) {
             $this->trigger(self::EVENT_BEFORE_SAVE_DISCOUNT, new DiscountEvent([
@@ -753,6 +759,10 @@ public function saveDiscount(Discount $model, bool $runValidation = true): bool
             $record->save(false);
             $model->id = $record->id;
 
+            // Update datetime attributes after save
+            $model->dateCreated = DateTimeHelper::toDateTime($record->dateCreated);
+            $model->dateUpdated = DateTimeHelper::toDateTime($record->dateUpdated);
+
             DiscountPurchasableRecord::deleteAll(['discountId' => $model->id]);
             DiscountCategoryRecord::deleteAll(['discountId' => $model->id]);
 

diff --git a/src/services/Sales.php b/src/services/Sales.php
@@ -24,6 +24,7 @@
 use craft\elements\Category;
 use craft\elements\Entry;
 use craft\helpers\ArrayHelper;
+use craft\helpers\DateTimeHelper;
 use DateTime;
 use yii\base\Component;
 use yii\base\Exception;
@@ -531,6 +532,12 @@ public function saveSale(Sale $model, bool $runValidation = true): bool
             $model->setPurchasableIds([]);
         }
 
+        // Make sure `dateCreated` and `dateUpdated` are set on the model
+        if (!$isNewSale) {
+            $model->dateCreated = DateTimeHelper::toDateTime($record->dateCreated);
+            $model->dateUpdated = DateTimeHelper::toDateTime($record->dateUpdated);
+        }
+
         // Fire an 'beforeSaveSection' event
         if ($this->hasEventHandlers(self::EVENT_BEFORE_SAVE_SALE)) {
             $this->trigger(self::EVENT_BEFORE_SAVE_SALE, new SaleEvent([
@@ -546,6 +553,10 @@ public function saveSale(Sale $model, bool $runValidation = true): bool
             $record->save(false);
             $model->id = $record->id;
 
+            // Update datetime attributes
+            $model->dateCreated = DateTimeHelper::toDateTime($record->dateCreated);
+            $model->dateUpdated = DateTimeHelper::toDateTime($record->dateUpdated);
+
             SaleUserGroupRecord::deleteAll(['saleId' => $model->id]);
             SalePurchasableRecord::deleteAll(['saleId' => $model->id]);
             SaleCategoryRecord::deleteAll(['saleId' => $model->id]);