Eager-load fields based on fields actually present in query #15684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonkelly hey Brandon - think I'm running into this issue right now; queries with handle overrides work perfectly in graphiql, but not via my gql API. I assume this is the fix I need, so how can I use it now? |
|
@howells This fix only improves the efficiency of queries, and it’s not passing tests yet so I wouldn’t recommend using it. Craft 5.4.2 fixed a bug related to overriding field handles. If you’re running 5.4.2+ and still experiencing an issue, please report it as a new GitHub issue. |
|
@brandonkelly no worries I got working again so can't have been related to this; a mystery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors how we resolve GraphQL field names to custom fields, so the fields in the element query are referenced rather than the global list of fields. That way any handle overrides can be accounted for.