Add tests for overlaps operator with DateTimes of varying precision. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24 but adds cases for DateTimes of varying precisions.
These cases can a bit challenging to think through. For reference, I implemented them in the google engine in google/cql#55
The important thing I ran into while implementing this overload was that there are cases added here where most interval checks can't be performed but one case definitely returns true. In order to accomplish this we checked the intervals for the following 4 cases:
1: left ends during right
2: left starts during right
3: right starts during left
4: right ends during left
If any returned true, the result is true, if any checks returned null then the result was null, otherwise false.