-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert cql-to-elm
to Kotlin Multiplatform (Kotlin feature branch)
#1495
Convert cql-to-elm
to Kotlin Multiplatform (Kotlin feature branch)
#1495
Conversation
cql-to-elm
to Kotlin Multiplatformcql-to-elm
to Kotlin Multiplatform (Kotlin feature branch)
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-kotlin #1495 +/- ##
====================================================
- Coverage 66.02% 61.70% -4.33%
+ Complexity 3001 1826 -1175
====================================================
Files 486 334 -152
Lines 28447 14108 -14339
Branches 5463 2878 -2585
====================================================
- Hits 18782 8705 -10077
+ Misses 7467 3971 -3496
+ Partials 2198 1432 -766 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
@JsExport | ||
fun cqlToElm( | ||
cqlText: String, | ||
getModelXml: ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice workaround for ServiceLoaders
What's included:
cql-to-elm
module is converted to Kotlin Multiplatform.kotlin.uuid.Uuid
only available since Kotlin 2.0).Stack
,isLeapYear
,isDigit
,isLetter
,isLetterOrDigit
.java.util.regex.Pattern
replaced withkotlin.text.Regex
.CqlCompiler
,CqlTranslator
,LibraryManager
,ModelManager
,LibrarySourceLoader
are split intoCommon*
and JVM-specific subclasses and subinterfaces.@JsExport
-friendly CQL-to-ELM helper (can be used to compile CQL to ELM in JS):