Skip to content

update homepage #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

update homepage #50

wants to merge 6 commits into from

Conversation

buitai97
Copy link
Collaborator

update header and footer of the homepage

Copy link
Collaborator

@Darren52BT Darren52BT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good full screen. some issues though;

  • the search bar does not match the figma; it should have the corresponding background across both light and dark mode and a magnifying glass as the search button.
  • for the footer the CS Central and logo are a little too big, try shrinking them
  • the spacing between the links on the right is too much; try shrinking the gaps
    image
    -when i shrink the screen the CS Catalog and logo become very large; even larger than it was full screen, please shrink them
    image

image
there's also some weird spacing going on here that causes everything to be off center

  • when the screen shrinks even further the CS Catalog becomes unrecognizable by shrinking, everything is off center, and the socials starting wrapping weirdly. For the socials container try setting it to never wrap.
    image

If you're having trouble trying to modify everything with the current structure you can always refactor the html and stuff. if you have any further questions lmk

@buitai97
Copy link
Collaborator Author

Screenshot 2024-04-26 210906
Updated footer as new design and make it responsive
Screenshot 2024-04-26 211021
Updated searchbox to match the figma design. CS-CENTRAL logo also changes corresponding dark and light modes

Copy link
Collaborator

@Darren52BT Darren52BT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the responsiveness looks a lot better, great job on that.
just a few minor changes;
image
image

  • if you compare it to the figma, you can see that the font needs to be more compact and smaller, and the socials and their labels need to have more space and the labels need to be smaller in comparison to the socials. additionally it looks like their font weight should be a little stronger.
  • the website logos seem to shrink a bit too much when i shrink screen; perhaps you could define a different size or a minimum size.
  • additionally it looks low res when the site is fully expanded on my screen. not sure if it's just me or not since my screen is pretty wide, but how did you get the image? you might want to check in with jeff on exporting the icon.
    image

@buitai97
Copy link
Collaborator Author

i have fixed the header and footer, and also added switch for light/dark mode by clicking the light bulb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants