add libp2p 0.1.26 #761
Open
add libp2p 0.1.26 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeroBurner
requested changes
Aug 29, 2024
| project(download-libp2p) | ||
|
|
||
| hunter_add_package(libp2p) | ||
| find_package(libp2p CONFIG REQUIRED) |
There was a problem hiding this comment.
Please add a duplicate find-pacjage call to have a check if the created package behaves nicely
| auto addr = Multiaddress::create("/ip4/192.168.0.1/tcp/8080"); | ||
| std::cout << "address: " << addr.value().getStringAddress() << std::endl; | ||
|
|
||
| // 创建一个 Peer ID |
There was a problem hiding this comment.
Could you remove the non ASCII character. I don't know what they mean and I want to prevent Unicode character mismatches
| @@ -0,0 +1,20 @@ | |||
| # Copyright (c) 2015, Ruslan Baratov | |||
There was a problem hiding this comment.
Update to 2024 and your name please
NeroBurner
reviewed
Aug 29, 2024
| @@ -379,6 +379,7 @@ hunter_default_version(libjson-rpc-cpp VERSION 0.7.0-p3) | |||
| hunter_default_version(libmill VERSION 1.18) | |||
| hunter_default_version(libogg VERSION 1.3.3-p0) | |||
| hunter_default_version(libpcre VERSION 8.41) | |||
| hunter_default_version(libp2p VERSION 0.1.26) | |||
There was a problem hiding this comment.
Need to reorder. From the failing builds
'libp2p' should appear before 'libpcre'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step by step carefully. [Yes]