Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake package for SIMD cpp library libsimdpp #748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joyeli
Copy link

@joyeli joyeli commented Jun 13, 2024

  • I've followed this guide
    step by step carefully. [Yes]

@joyeli joyeli changed the title Add cmake pacakge for SIMD cpp library libsimdpp Add cmake package for SIMD cpp library libsimdpp Jun 13, 2024
@@ -0,0 +1,15 @@
cmake_minimum_required(VERSION 3.2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please increase minimum version to 3.5

Suggested change
cmake_minimum_required(VERSION 3.2)
cmake_minimum_required(VERSION 3.5)

PACKAGE_NAME
libsimdpp
VERSION
2.x-p0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this mystery version?

@NeroBurner
Copy link

@joyeli any updates on the requested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants