-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add package tcmalloc #493
base: master
Are you sure you want to change the base?
add package tcmalloc #493
Conversation
@craffael I don't know what we should do to test this package. Thoughts? |
(without bumping the CMake version in CI, necessarily) |
Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's? |
Alternatively you could also just let the ci fail for tcmalloc... I guess there are not so many packages which require such a recent version of cmake... |
No problem, I've been pretty slow these days too... Sure, let's do that and I can review. |
any updates on this? |
step by step carefully. Yes
Note that currently all ci-jobs fail because the tcmalloc needs cmake 3.21 or higher. Maybe it would be an option to bump cmake version in polly's
install-ci-dependencies.py
...?