Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package tcmalloc #493

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add package tcmalloc #493

wants to merge 5 commits into from

Conversation

craffael
Copy link

  • I've followed this guide
    step by step carefully. Yes

Note that currently all ci-jobs fail because the tcmalloc needs cmake 3.21 or higher. Maybe it would be an option to bump cmake version in polly's install-ci-dependencies.py...?

@rbsheth
Copy link
Member

rbsheth commented Dec 16, 2021

@craffael I don't know what we should do to test this package. Thoughts?

@rbsheth
Copy link
Member

rbsheth commented Dec 16, 2021

(without bumping the CMake version in CI, necessarily)

@craffael
Copy link
Author

Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's?

@craffael
Copy link
Author

Alternatively you could also just let the ci fail for tcmalloc... I guess there are not so many packages which require such a recent version of cmake...

@rbsheth
Copy link
Member

rbsheth commented Feb 3, 2022

Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's?

No problem, I've been pretty slow these days too... Sure, let's do that and I can review.

@NeroBurner
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants