Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imgui to 1.82-docking #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tolstenko
Copy link

  • I've followed this guide
    step by step carefully. [Yes]

Yes, but I had one issue. I couldn't send a merge request from my branch from my repo to a branch that does not exist in the origin. The imgui's branch 'docking' does not exist in the https://github.com/hunter-packages/imgui and I don't have access to properly create the branch docking to map the branch docking from imgui. So I couldn't create the merge request to a branch that doesn't exist in the hunter-packages/imgui .

I did a fork at https://github.com/InfiniBrains/imgui and put my changes there, I created the branch properly etc...

Pls guide me in the better way to address this issue, so the imgui would be updated properly.

@rbsheth
Copy link
Member

rbsheth commented Mar 24, 2021

Hi @tolstenko, thanks for your contribution! Typically we create a new fork in https://github.com/cpp-pm and then update the branch accordingly. https://github.com/hunter-packages is deprecated and will not be updated.

I made a Hunter branch for you here: https://github.com/cpp-pm/imgui/tree/hunter-docking-085cff2

First, make a PR with your Hunterization changes to that branch. Once approved and merged, we can cut a release and you can use that release here in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants