Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Verify if the hunter id path is the same as before #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bjoe
Copy link

@Bjoe Bjoe commented Mar 17, 2020

  • I've checked this Git style guide. Yes
  • I've checked this CMake style guide. Yes
  • My change will work with CMake 3.2 (minimum requirement for Hunter). Yes
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. Yes

This is a proposal of the following error in PR #139

@Bjoe Bjoe changed the title Verify if the hunter id path is the same as before WIP: Verify if the hunter id path is the same as before Mar 17, 2020
@Bjoe
Copy link
Author

Bjoe commented Mar 17, 2020

But maybe it is better to cache Hunter-ID, Config-ID and Toolchain-ID ... if some of them are changed, then we should throw an error....

@NeroBurner
Copy link

is it possible to create a test, that would trigger this check?

https://github.com/cpp-pm/hunter/tree/master/tests

@Bjoe
Copy link
Author

Bjoe commented Mar 18, 2020

@NeroBurner Yep would be a good idea. Let me figured out, I'm not sure yet. But again, take some time :-)

@NeroBurner
Copy link

any updates on this?

@Bjoe
Copy link
Author

Bjoe commented Nov 23, 2022

@NeroBurner Unfortunately no progress yet. I tried long time ago and I was some stuck. Then I changed the company + my private hard drive crashed and I need to setup my environment again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants