P3570R2 optional variants in sender/receiver #8003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisdairM
force-pushed
the
apply_p3570_optional_variants_in_sender_receiver
branch
from
99d6617 to
83f7446
Compare
Eisenwave
reviewed
Jun 23, 2025
Co-authored-by: Jan Schultke <[email protected]>
Eisenwave
approved these changes
Jun 23, 2025
|
I have 3 overfull boxes that I could use help to resolve: Error: Overfull \hbox (14.032pt too wide) in paragraph at lines 1017--1021 |
Eisenwave
reviewed
Jun 23, 2025
| its associated awaitable completion adaptor. | ||
|
|
||
| \pnum | ||
| The name \tcode{get_await_completion_adaptor} denotes a query object. |
There was a problem hiding this comment.
You can probably resolve the overfull hbox issues in this area by sprinkling some soft hyphens (\-) into these long identifiers.
Comment on lines
+5611
to
+5616
| Otherwise, \tcode{\exposid{sender-awaitable}\{\exposid{adapted-expr}, p\}} | ||
| if \tcode{\exposid{has-queryable-await-completion-adaptor}<Expr>} | ||
| and \tcode{\exposid{awaitable-sender}<decltype((\exposid{adapted-expr})), Promise>} | ||
| are both satisfied, where \exposid{adapted-expr} is | ||
| \tcode{get_await_completion_adaptor(get_env(expr))(expr)}, | ||
| except that \tcode{expr} is evaluated only once. |
There was a problem hiding this comment.
Sprinkling in some soft hyphens (\-) into names and optional word breaks (\brk{}) after opening parentheses and punctuation should do the trick here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7955
Fixes cplusplus/papers#2249