-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google drive support #93
base: master
Are you sure you want to change the base?
Conversation
Made lots of improvements, I think it's basically ready to go now. Please let me know what you think.. |
tapiriik/local_settings.py.example
Outdated
@@ -7,6 +7,9 @@ DROPBOX_FULL_APP_SECRET = "####" | |||
DROPBOX_APP_KEY = "####" | |||
DROPBOX_APP_SECRET = "####" | |||
|
|||
GOOGLEDRIVE_CLIENT_ID = "####" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a special google drive credential? Or just a google app credential (thinking about when I get around to doing Google Fit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. You can add multiple google APIs to the same project and make it a single confirmation from the user - so I guess it depends whether you want to tie the two of them together or not. If you make them separate projects and allow people to hook up just one they'll have different client ID/client secret pairs. The other option would just be to have one "Google" sync option and then make the fit/drive question user-configurable I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, you can create projects and configure the APIs they use at https://console.developers.google.com
|
It would be nice to merge this request! |
Any news on the progress of this pull request? I hope we can make the most of @mduggan's great work. |
Hey guys, any update on this one? |
Bump for interest! |
Definitely needed for people with many activities and without paid Dropbox. |
How far away is this from being merged? |
Any update on this one? Would really like to see Drive added as a sync option! |
Hello, any news on this merge? Would be great to see Google Drive added. |
Looks like this is abandoned? |
da1b4e7
to
1081891
Compare
7be379e
to
d509992
Compare
I've rebased this and updated to work with the latest version of the dependencies. It still works fine. The |
What's the status? I'm new to GitHub and see that some have been "force-pushed" but it's not listed on the website? |
In this case "force-pushed" means that I updated my copy of it with a new one and discarded my old attempt. It's still up to @cpfair whether he wants to merge my changes - I think they are good to go, other than the fact that |
I think this is just about ready to go now. Looking for feedback if you have some time to look at it.
The main TODO item is support configuration like the Dropbox service does
This addresses #82.