Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google drive support #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mduggan
Copy link
Contributor

@mduggan mduggan commented Jan 24, 2015

I think this is just about ready to go now. Looking for feedback if you have some time to look at it.

The main TODO item is support configuration like the Dropbox service does

This addresses #82.

@mduggan mduggan changed the title Google drive support (WIP) Google drive support Jan 31, 2015
@mduggan
Copy link
Contributor Author

mduggan commented Jan 31, 2015

Made lots of improvements, I think it's basically ready to go now. Please let me know what you think..

@@ -7,6 +7,9 @@ DROPBOX_FULL_APP_SECRET = "####"
DROPBOX_APP_KEY = "####"
DROPBOX_APP_SECRET = "####"

GOOGLEDRIVE_CLIENT_ID = "####"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a special google drive credential? Or just a google app credential (thinking about when I get around to doing Google Fit).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. You can add multiple google APIs to the same project and make it a single confirmation from the user - so I guess it depends whether you want to tie the two of them together or not. If you make them separate projects and allow people to hook up just one they'll have different client ID/client secret pairs. The other option would just be to have one "Google" sync option and then make the fit/drive question user-configurable I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, you can create projects and configure the APIs they use at https://console.developers.google.com

@natelowry
Copy link
Contributor

StorageServiceBase will be awesome for adding OneDrive #143. Any timeline for when this will get merged? 😻

@NeverI
Copy link

NeverI commented Oct 3, 2015

It would be nice to merge this request!

@andre-abadi
Copy link

Any news on the progress of this pull request? I hope we can make the most of @mduggan's great work.

@patricksan
Copy link

Hey guys, any update on this one?

@Zoxjib
Copy link

Zoxjib commented Mar 8, 2016

Bump for interest!

@randybb
Copy link

randybb commented Aug 31, 2016

Definitely needed for people with many activities and without paid Dropbox.

@piquet-h
Copy link

How far away is this from being merged?

@bsiver
Copy link

bsiver commented Jan 25, 2017

Any update on this one? Would really like to see Drive added as a sync option!

@mat-ray
Copy link

mat-ray commented Feb 24, 2017

Hello, any news on this merge? Would be great to see Google Drive added.

@bisraelsen
Copy link

Looks like this is abandoned?

@mduggan mduggan force-pushed the google-drive-support branch from 7be379e to d509992 Compare December 29, 2021 11:05
@mduggan
Copy link
Contributor Author

mduggan commented Dec 29, 2021

I've rebased this and updated to work with the latest version of the dependencies. It still works fine. The oauth2client package has been deprecated so probably should be updated to something newer like oauthlib.

@brisdaz
Copy link

brisdaz commented Apr 18, 2022

What's the status? I'm new to GitHub and see that some have been "force-pushed" but it's not listed on the website?

@mduggan
Copy link
Contributor Author

mduggan commented Apr 19, 2022

In this case "force-pushed" means that I updated my copy of it with a new one and discarded my old attempt. It's still up to @cpfair whether he wants to merge my changes - I think they are good to go, other than the fact that oauth2client is deprecated - it works fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.