th#1043: joint precision fit for shared-component multi-lane loads#373
Merged
Conversation
Sequential per-lane loading let the first lane in a gw#479 shared-
component group (qwen-image's t2i/edit) consume free VRAM at native
precision, starving the second lane into an offload placement the
shared-component invariant refuses outright ("shared-component lanes
require resident placement"). Decide fp8 storage for the whole group
up front, against its combined footprint, before any lane loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetryableError("shared-component lanes require resident placement").editlane resident at bf16 (~40GB transformer + ~15.5GB shared encoder), leaving too little free VRAM for thet2ilane's transformer, which then required offload and was refused.Test plan
tests/test_shared_lane_precision_th1043.py) cover: starved group forces fp8 when it fits; group that fits natively is untouched; group that can't fit even at fp8 is left to the existing per-lane ladder; single-lane / no-shared-components never force.mypyclean on touched filesruff checkclean on touched filespytestsuite green (one pre-existing unrelated flake intest_activity_gw601.py, confirmed to pass in isolation — timing-sensitive under shared-box load, not touched by this change)