-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore: upgrade eslint version #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
tecvan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
tecvan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrade ESLint across the monorepo and related tooling to a newer 9.x release, with minor related dependency bumps.
- Bump eslint from ~9.12.0 to ~9.34.0 across packages.
- Align @typescript-eslint/parser to ~8.43.0 in configs/plugins.
- Minor: bump webpack from ~5.89.0 to ~5.91.0 in pkg-root-webpack-plugin.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/packages/project-ide/view/package.json | Upgrade eslint to ~9.34.0 for the view package tooling. |
| frontend/packages/project-ide/core/package.json | Upgrade eslint to ~9.34.0 for the core package tooling. |
| frontend/packages/project-ide/client/package.json | Upgrade eslint to ~9.34.0 for the client package tooling. |
| frontend/infra/plugins/pkg-root-webpack-plugin/package.json | Bump webpack to ~5.91.0 to keep plugin tooling current. |
| frontend/infra/eslint-plugin/package.json | Upgrade eslint to ~9.34.0 and bump @typescript-eslint/parser to ~8.43.0 in the custom ESLint plugin. |
| frontend/config/ts-config/package.json | Upgrade eslint to ~9.34.0 in the TS config package. |
| frontend/config/eslint-config/package.json | Upgrade eslint to ~9.34.0 and bump @typescript-eslint/parser to ~8.43.0 in the shared ESLint config. |
| common/autoinstallers/rush-lint-staged/package.json | Upgrade eslint to ~9.34.0 for lint-staged autoinstaller. |
Files not reviewed (2)
- common/autoinstallers/rush-lint-staged/pnpm-lock.yaml: Language not supported
- common/config/subspaces/default/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "@typescript-eslint/eslint-plugin": "^8.5.0", | ||
| "@typescript-eslint/parser": "~8.17.0", | ||
| "@typescript-eslint/parser": "~8.43.0", | ||
| "@typescript-eslint/rule-tester": "~8.10.0", |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The @typescript-eslint packages are on mismatched versions (^8.5.0, ~8.10.0, ~8.43.0). It's recommended to keep @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and @typescript-eslint/rule-tester on the same version to avoid peer-dependency warnings and subtle incompatibilities; consider aligning all three to the same 8.43.x line.
| "@eslint/eslintrc": "~3.1.0", | ||
| "@rushstack/eslint-config": "~3.1.1", | ||
| "@stylistic/eslint-plugin-ts": "^2.8.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.5.0", |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Versions for @typescript-eslint/eslint-plugin and @typescript-eslint/parser are out of sync. Align them to the same minor/patch (e.g., both ~8.43.0) to ensure consistent rule behavior and avoid peer-dependency resolution issues.
| "@typescript-eslint/eslint-plugin": "^8.5.0", | |
| "@typescript-eslint/eslint-plugin": "~8.43.0", |
8c1aed5 to
da21ff6
Compare
chore: update lock
233cf6c to
92fc7ea
Compare
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: