Skip to content

Update package.json #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update package.json #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/coze-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
"test:cov": "vitest --coverage --run"
},
"dependencies": {
"agora-extension-ai-denoiser": "^1.0.0",
"agora-rtc-sdk-ng": "4.23.2-1",
"agora-extension-ai-denoiser": "^1.1.0",
"agora-rtc-sdk-ng": "4.24.0",
Comment on lines +63 to +64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Bump looks good; verify the deprecation is actually gone and consider loosening the pin.

  • The upgrades to agora-extension-ai-denoiser@^1.1.0 and [email protected] look fine.
  • Please confirm the original warning about [email protected] is eliminated across the workspace lockfile. If it persists, add an override for node-domexception to ^2.0.1.
  • Optional: for a library, consider ^4.24.0 instead of an exact 4.24.0 to avoid over-constraining consumers (unless you intentionally want a hard pin for reproducibility). Your existing overrides keeps the extension aligned anyway.

Apply if the warning persists:

   "overrides": {
     "agora-extension-ai-denoiser": {
       "agora-rtc-sdk-ng": "$agora-rtc-sdk-ng"
-    }
+    },
+    "node-domexception": "^2.0.1"
   }

Run to verify:

🏁 Script executed:

#!/bin/bash
# 1) Check if deprecated version still exists
rg -n "node-domexception@1\.0\.0" pnpm-lock.yaml || true

# 2) Find why it's pulled in
pnpm why node-domexception || true

# 3) Ensure only one Agora SDK version is resolved
rg -n "^ {2}agora-rtc-sdk-ng@" pnpm-lock.yaml -n -C0 || true

Length of output: 258

🏁 Script executed:

#!/bin/bash
# List top-level files to locate lockfiles
find . -maxdepth 1 -type f -printf '%f\n'

# Search for common lockfiles across the repo
find . -type f \( -iname "yarn.lock" -o -iname "package-lock.json" -o -iname "pnpm-lock.yaml" \) -maxdepth 3

Length of output: 375

🏁 Script executed:

#!/bin/bash
# Display the beginning of rush.json to locate lockfile configuration
sed -n '1,200p' rush.json

Length of output: 11146

🏁 Script executed:

#!/usr/bin/env bash
# Search for deprecated node-domexception across all workspace lockfiles
find . -type f \( -iname "pnpm-lock.yaml" -o -iname "yarn.lock" -o -iname "package-lock.json" \) \
  -exec echo "Scanning {}" \; \
  -exec rg -n "node-domexception@" {} \; || true

Length of output: 596

🏁 Script executed:

#!/usr/bin/env bash
# Find any pnpm override configuration or pnpmfile
find . -type f \( -iname "pnpmfile.js" -o -iname "package.json" \) -maxdepth 4 \
  -exec grep -Hn '"overrides"' {} \; || true

Length of output: 169

Add override for node-domexception

  • Lockfiles still resolve [email protected]; under overrides in packages/coze-js/package.json append: 
       "overrides": {
     "agora-extension-ai-denoiser": {
       "agora-rtc-sdk-ng": "$agora-rtc-sdk-ng"
  •  }

  •  },

  •  "node-domexception": "^2.0.1"
    } 
    then run `rush update` or `pnpm install` to confirm `node-domexception@^2.0.1` is now resolved.
  • Optional: loosen the pin on "agora-rtc-sdk-ng": "4.24.0" to "^4.24.0" to avoid over-constraining consumers.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"agora-extension-ai-denoiser": "^1.1.0",
"agora-rtc-sdk-ng": "4.24.0",
// In packages/coze-js/package.json, update (or create) the "overrides" section as follows:
{
// … other top-level fields …
"overrides": {
"agora-extension-ai-denoiser": {
"agora-rtc-sdk-ng": "$agora-rtc-sdk-ng"
},
"node-domexception": "^2.0.1"
}
// … the rest of the file …
}
🤖 Prompt for AI Agents 
In packages/coze-js/package.json around lines 63 to 64, the dependency graph
still resolves [email protected]; add an overrides section to force
node-domexception@^2.0.1 (e.g. append an "overrides": {"node-domexception":
"^2.0.1"} entry at the root of the package.json) and then run rush update or
pnpm install to verify the lockfile now resolves node-domexception@^2.0.1;
optionally loosen the agora-rtc-sdk-ng pin from "4.24.0" to "^4.24.0" to avoid
over-constraining consumers.

"agora-rte-extension": "^1.2.4",
"jsonwebtoken": "^9.0.2",
"node-fetch": "^2.x",
Expand Down
Loading