Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arb1 images for several tokens #406

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

alfetopito
Copy link
Collaborator

Summary

Adding images for all tokens that had it missing from this list https://tokenlists.org/token-list?url=https://raw.githubusercontent.com/cowprotocol/token-lists/113aa571bc7ed208d7ed76e4b7481aeb5b107178/src/public/ArbitrumOneCoingeckoTokensList.json

Some are terrible, and they were the best I could find.
Optimized all of them.

And 2 of them are actually jpgs pretending to be pngs 🤫

Testing

Visually check them

Once merged, they can be added to https://github.com/cowprotocol/token-lists/blob/aa4bc7cb7d413bafcd23f25bbfc005e66b3c483a/src/scripts/arbitrum/tokens-with-liquidity-arbitrum.csv

@alfetopito alfetopito self-assigned this Jun 6, 2024
@alfetopito alfetopito requested a review from a team June 6, 2024 16:10
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the first 8 addresses, they matched, then got lazy and trusted your good skills

This one, is a bit low quality:
src/public/images/42161/0x431402e8b9de9aa016c743880e04e517074d8cec/logo.png

@alfetopito
Copy link
Collaborator Author

0x431402e8b9de9aa016c743880e04e517074d8cec

I got this one from arbiscan https://arbiscan.io/token/0x431402e8b9dE9aa016C743880e04E517074D8cEC.
That's because the one on uniswap https://raw.githubusercontent.com/Uniswap/assets/master/blockchains/ethereum/assets/0x584bC13c7D411c00c01A62e8019472dE68768430/logo.png doesn't match the project's design https://www.hegic.co/
Also could not find anything in their website about a media kit or similar 🤷

@alfetopito
Copy link
Collaborator Author

Found a better one that look similar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to optimize the images.
https://tinypng.com/

this one can be 50% less

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already did, using the same methods we had before:

  1. imageoptim
  2. imagemagick: convert -depth 7 -resize 256x -posterize 48

@alfetopito alfetopito merged commit 4d81580 into main Jun 7, 2024
5 checks passed
@alfetopito alfetopito deleted the feat/add-arb1-images branch June 7, 2024 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants