Skip to content

Disable ANALYZE on read-only replica #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −12
Open

Disable ANALYZE on read-only replica #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
935e508
Disable ANALYZE on read-only replica
jmg-duarte Dec 1, 2025
38aeabc
Change the connection being used
jmg-duarte Dec 3, 2025
872c04f
Change the connection being used
jmg-duarte Dec 3, 2025
d4ac5a8
Fix the db conn
jmg-duarte Dec 3, 2025
3a24f20
Fix lint
jmg-duarte Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/autopilot/src/database/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ pub fn run_database_metrics_work(db: Postgres) {
let span = tracing::info_span!("database_metrics");
// Spawn the task for updating large table statistics
tokio::spawn(update_large_tables_stats(db.clone()).instrument(span.clone()));

// Spawn the task for database metrics
tokio::task::spawn(database_metrics(db).instrument(span));
}
Expand Down
14 changes: 3 additions & 11 deletions crates/autopilot/src/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,9 @@ pub async fn run(args: Arguments, shutdown_controller: ShutdownController) {
.await
.unwrap();

let db_read = if let Some(db_read_url) = args.db_read_url
&& args.db_write_url != db_read_url
{
Postgres::new(db_read_url.as_str(), args.insert_batch_size)
.await
.expect("failed to create read replica database")
} else {
db_write.clone()
};
Comment on lines -176 to -184
Copy link
Contributor

@m-sz m-sz Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing the read replica functionality from autopilot (since it was pretty much just for the db metrics), let's also remove the command line arguments for it. It can be done by changing the deployment (to not configure --db-read-url) and then deploying this PR I presume.

The rolling update strategy has to be taken into consideration.


crate::database::run_database_metrics_work(db_read.clone());
// If the DB is in read-only mode, running ANALYZE is not possible and will
// trigger and error https://www.postgresql.org/docs/current/hot-standby.html
crate::database::run_database_metrics_work(db_write.clone());

let http_factory = HttpClientFactory::new(&args.http_client);
let web3 = shared::ethrpc::web3(
Expand Down
Loading