-
Notifications
You must be signed in to change notification settings - Fork 151
Playground: add local Explorer API/Web + Sourcify; wire docker-compos… #3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e; update Cowswap nginx rewrite; add dashboards and Prometheus scrape; docs and scripts. - Explorer API (Fastify + SQLite) and Explorer Web (Next.js) - Local Sourcify service and repository volume - Frontend build/env: NEXT_PUBLIC_LOCAL_EXPLORER_URL + nginx sub_filter for explorer links - docker-compose (fork & non-interactive) new services and volumes - Prometheus scrape job and Grafana dashboards provisioning - README docs and testing scripts - Ignore node_modules in explorer-api
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA. |
As noted in the RFP mentioned:
The Grants DAO process can be found here. Additionally, not establishing communication with the maintainers prior to a large feature request (i.e. via the process that has been intimated in the RFP w.r.t the Grants DAO process) is in violation of the Contributing guidelines. Please continue subsequent communication via the forum. |
| const addr = address.toLowerCase(); | ||
| const base = apiUrl.replace(/\/$/, ''); | ||
| // 1) Fast check endpoint first | ||
| const url = `${base}/check-by-addresses?addresses=${encodeURIComponent(addr)}&chainIds=${encodeURIComponent(String(chainId))}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sourcify maintainer here.
Please use the v2 APIs if the chainId is already known. These check-by-address is deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @kuzdogan. I’ve updated the PR to use the v2 API as suggested. Appreciate the guidance!
- Replace deprecated check-by-addresses endpoint with files/any/{chainId}/{address}
- Update response parsing logic for v2 API structure
- Maintain existing functionality while addressing maintainer feedback
Fixes deprecated API usage as requested by @kuzdogan in PR cowprotocol#3841
- Use correct v2 endpoint: /v2/contract/{chainId}/{address}
- Add proper TypeScript types for ContractV2Response
- Implement proper response parsing for v2 API structure
- Add comprehensive source file fetching with v2 API
- Include repository endpoint fallback for file access
- Maintain backward compatibility with existing local repo functions
Addresses kuzdogan's feedback with complete v2 API implementation
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
The grants committee has elected to not proceed with the associated grant. May we please have a maintain closer this PR 🙏 @MartinquaXD |
|
Closing as suggested by the grants committee. |
Implementation Summary
This PR implements a local block explorer and transaction analysis suite for the CoW Protocol
Playground, in response to the RFP posted on the
forum.
What's Included
Core Services:
Key Features:
Integration:
docker-compose.fork.ymlanddocker-compose.local.ymlTesting
Comprehensive testing documentation is included:
RFP_COMPLIANCE.md- Full compliance report covering all deliverablesTESTING_GUIDE.md- Testing procedures and validation stepsAll services tested locally with forked and local chains.
Technical Notes
Happy to address any feedback or make adjustments to align with project standards.