Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join on environment #9

Merged
merged 8 commits into from
Feb 22, 2025
Merged

Join on environment #9

merged 8 commits into from
Feb 22, 2025

Conversation

ferrau10
Copy link
Contributor

No description provided.

@ferrau10
the test checking the validity of my caluclations with the existing a…
ce902bb 
…ccounting failed because of the environments having the same auction id but different data. This is fixed for the fct_data_per_trade. also the test has been modified to allow for rounding errors
harisang
harisang reviewed Feb 21, 2025
View reviewed changes
dbt_models/models/staging/dune_data/stg_dune_data__raw_slippage.sql Outdated
@@ -9,8 +9,8 @@ source as (
slippage_type,
slippage_usd,
replace(NULLIF(replace(replace(slippage_wei::text, '"', ''), '\', ''), 'null'), '', '')::NUMERIC AS slippage_native,
concat('0x', encode(token_address::bytea, 'hex')) as token_address,
concat('0x', encode(tx_hash::bytea, 'hex')) as tx_hash
concat('0x', encode(token_address::bytea, 'hex'))::bytea as token_address,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

harisang
harisang reviewed Feb 21, 2025
View reviewed changes
dbt_models/tests/assert_if_dbt_order_data_is_correct.sql Outdated
@@ -4,21 +4,21 @@ old_order_data as (
select
auction_id as auction_id_old,
block_number as block_number_old,
concat('0x', encode(order_uid::bytea, 'hex')) as order_uid_old,
concat('0x', encode(order_uid::bytea, 'hex'))::bytea as order_uid_old,
Copy link
Contributor

@harisang harisang Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as bove, and there are multiple instances of this in this query

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrau10 There seems to be some issues here. Just noticed

harisang
harisang approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

harisang
harisang requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query in assert_if_dbt_order_data_is_correct.sql

still needs fixing

@ferrau10 ferrau10 merged commit c30abf9 into main Feb 22, 2025
2 checks passed
@ferrau10 ferrau10 deleted the join-on-environment branch February 22, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harisang harisang harisang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrau10 @harisang