chore(atomic): migrate atomic-insight-result-children-template to Lit#7171
Open
alexprudhomme wants to merge 21 commits intomainfrom
Open
chore(atomic): migrate atomic-insight-result-children-template to Lit#7171alexprudhomme wants to merge 21 commits intomainfrom
alexprudhomme wants to merge 21 commits intomainfrom
Conversation
- Migrate Stencil component to Lit using ResultTemplateController - Make component public (remove @internal) - Add unit tests (7 test cases) - Add e2e test infrastructure (page-object, fixture, e2e spec) - Add Storybook stories (Default, WithConditions, WithNestedChildren) - Add MDX documentation - Update parent component import - Delete old Stencil component
…ldrenTemplateObject
…hildren-template (#7178) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fbeaudoincoveo <23503066+fbeaudoincoveo@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
This is the last Stencil component we're migrating. We no longer need the Atomic Insight Cypress tests. Bye bye!
| * For example, a template with the following attribute only applies to child results whose `filetype` and `sourcetype` fields are defined: | ||
| * `if-defined="filetype,sourcetype"` | ||
| */ | ||
| @property({type: String, attribute: 'if-defined'}) ifDefined?: string; |
Contributor
There was a problem hiding this comment.
Note that this prop and ifNotDefined are not present in the atomic-result-children-template (i.e., the search version). I'm leaving them here to avoid breaking changes, but there's a discrepancy.
louis-bompart
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
atomic-insight-result-children-templatefrom Stencil to Lit, following the same patterns established by the search-equivalentatomic-result-children-template.What changed
ResultTemplateController,@errorGuard(),@mapProperty, and@withTailwindStylesdecorators@coveo/headless/insightinstead of@coveo/headless(the Stencil original used the less-specific import)connectedCallbackmatch conditions,getTemplatedelegation, render output, and error renderinginherit-templates), With conditionsindex.ts,lazy-index.ts,custom-element-tags.ts, andcomponents.d.tsScout camping
atomic-result-children-template.spec.ts(search sibling): fixedmockResolvedValue→mockReturnValue(getTemplateis synchronous) and.toBeDefined()→.not.toBeNull()(vacuous assertion onquerySelectorreturn)Editorial choices
allowEmptykept asfalse(matching the Stencil original default) rather than setting it totruenestedFoldedResponsewith grandchildren for the nested storymock()instead ofmockOnceinbeforeEach, so the Storybook Docs page renders all stories correctly (shared harness was being exhausted)@internaltag removed — intentional, needed for Storybook custom element manifest generationChecklist
.mdxfile♿ The component complies with the Web Content Accessibility Guidelines.N/A: Template-only component; rendersnothing— accessibility depends on slotted content🌐 All strings intended for humans or assistive technology must be localized with i18n.N/A: No user-facing stringsindex.tsandlazy-index.tsfiles.🎨 CSS parts are documented still accessible.N/A: Component rendersnothing; no CSS parts🔄 The component outputs the same Angular output as before with StencilN/A: Template component — not wrapped in Angularhttps://coveord.atlassian.net/browse/KIT-5481