feat(atomic) creation of agent generation steps component#7165
Open
SimonMilord wants to merge 11 commits intomainfrom
Open
feat(atomic) creation of agent generation steps component#7165SimonMilord wants to merge 11 commits intomainfrom
SimonMilord wants to merge 11 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Atomic (Lit) functional renderer intended to display agent generation steps (search/think/generate) while a generated answer is streaming, along with supporting localization strings, styling for a rolodex-like transition, and unit tests.
Changes:
- Added new i18n keys for agent “search” and “think” generation steps.
- Added generated-answer CSS keyframes/selectors for a rolodex animation.
- Added
renderAgentGenerationStepsfunctional component plus helper functions and unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/atomic/src/locales.json | Adds new localized strings for agent generation step labels. |
| packages/atomic/src/components/common/generated-answer/styles/generated-answer.tw.css.ts | Adds keyframes and styling hooks for the generation-steps rolodex animation. |
| packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts | Introduces a new functional renderer + step-selection helpers for agent generation steps. |
| packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts | Adds unit tests covering rendering and step-selection behavior. |
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/styles/generated-answer.tw.css.ts
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Show resolved
Hide resolved
16a50f8 to
fc70014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFINT-6647
IN THIS PR:
Note about the component:
For which label to display, it follows this logic:
Selection priority:
-> for example, if the search step last 400ms, it will continue to display for a minimum of 1500ms (the duration of the rolodex animation)
DEMO:
Screen.Recording.2026-02-25.at.2.53.58.PM.mov