Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Stencil-based React proxy generation path for Atomic, and relies on the Lit/@lit/react-based wrapper generation instead. It also cleans up now-unneeded dependencies, patches, and build scripts tied to the Stencil React output target.
Changes:
- Remove
@stencil/react-output-targetusage frompackages/atomic/stencil.config.tsand drop the dependency/patches. - Stop re-exporting Stencil-generated React bindings from
@coveo/atomic-reactentrypoints (search/commerce/recommendation). - Simplify
@coveo/atomic-reactbuild scripts by removing the import-path “fixup” steps and thefix-esm-import-pathdependency.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removes @stencil/react-output-target and fix-esm-import-path entries and related patch metadata. |
| patches/fix-esm-import-path+1.10.1.patch | Deletes patch file no longer referenced. |
| patches/@stencil__react-output-target@0.5.3.patch | Deletes patch file no longer referenced. |
| packages/atomic/stencil.config.ts | Removes Stencil React output targets and the helper that computed excluded components for React proxy generation. |
| packages/atomic/package.json | Drops @stencil/react-output-target devDependency. |
| packages/atomic-react/src/components/search/index.ts | Stops re-exporting stencil-generated bindings; exports only Lit wrappers/wrappers. |
| packages/atomic-react/src/components/recommendation/index.ts | Stops re-exporting stencil-generated bindings. |
| packages/atomic-react/src/components/commerce/index.ts | Stops re-exporting stencil-generated bindings. |
| packages/atomic-react/scripts/fix-loader-import-paths.js | Removes script used to post-process Stencil-generated output. |
| packages/atomic-react/package.json | Simplifies gen:lit and removes the two “fix generated imports” scripts and fix-esm-import-path devDependency. |
| package.json | Removes pnpm patch entries for @stencil/react-output-target and fix-esm-import-path. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff-dist: https://gist.github.com/louis-bompart/8ba10256a1354770d885405f3160d8fa
The changes in the diff are about internal code/types.