Skip to content

chore: eject react build from Stencil#7160

Open
louis-bompart wants to merge 1 commit intomainfrom
KIT-5412
Open

chore: eject react build from Stencil#7160
louis-bompart wants to merge 1 commit intomainfrom
KIT-5412

Conversation

@louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Feb 23, 2026

diff-dist: https://gist.github.com/louis-bompart/8ba10256a1354770d885405f3160d8fa
The changes in the diff are about internal code/types.

@github-actions
Copy link

🔗 Scratch Orgs ready to test this PR:

@louis-bompart louis-bompart changed the title WIP; code ready: no more stencil react chore: eject react build from Stencil Feb 24, 2026
@louis-bompart louis-bompart marked this pull request as ready for review February 24, 2026 20:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Stencil-based React proxy generation path for Atomic, and relies on the Lit/@lit/react-based wrapper generation instead. It also cleans up now-unneeded dependencies, patches, and build scripts tied to the Stencil React output target.

Changes:

  • Remove @stencil/react-output-target usage from packages/atomic/stencil.config.ts and drop the dependency/patches.
  • Stop re-exporting Stencil-generated React bindings from @coveo/atomic-react entrypoints (search/commerce/recommendation).
  • Simplify @coveo/atomic-react build scripts by removing the import-path “fixup” steps and the fix-esm-import-path dependency.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Removes @stencil/react-output-target and fix-esm-import-path entries and related patch metadata.
patches/fix-esm-import-path+1.10.1.patch Deletes patch file no longer referenced.
patches/@stencil__react-output-target@0.5.3.patch Deletes patch file no longer referenced.
packages/atomic/stencil.config.ts Removes Stencil React output targets and the helper that computed excluded components for React proxy generation.
packages/atomic/package.json Drops @stencil/react-output-target devDependency.
packages/atomic-react/src/components/search/index.ts Stops re-exporting stencil-generated bindings; exports only Lit wrappers/wrappers.
packages/atomic-react/src/components/recommendation/index.ts Stops re-exporting stencil-generated bindings.
packages/atomic-react/src/components/commerce/index.ts Stops re-exporting stencil-generated bindings.
packages/atomic-react/scripts/fix-loader-import-paths.js Removes script used to post-process Stencil-generated output.
packages/atomic-react/package.json Simplifies gen:lit and removes the two “fix generated imports” scripts and fix-esm-import-path devDependency.
package.json Removes pnpm patch entries for @stencil/react-output-target and fix-esm-import-path.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants