fix: "extras" and "all-extras" not applied for environments created by stew #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonapich
requested review from
jebeaudet,
dblanchette,
klalumiere and
nicolegros
it was done during stew ci for a while, just not for new envs
dblanchette
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
stew cion a project without a virtual environment setup, we usepoetry installto delegate the work to poetry. We don't use theself.install()method because it would create an infinite loop (the install method requires an environment). This causes the behaviors aroundextrasto be lost since it was in theinstall()method.I extracted the command creation logic and reused it in both code paths.