Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add patch-package to prd dep, enhance modal-box patch #1986

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: add patch-package to prd dep, enhance modal-box patch #1986

merged 1 commit into from
Sep 10, 2024

Conversation

louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Sep 3, 2024 •
edited
Loading

JSUI-3531

  • Add patch-package as a prd dep
  • Ensure patch is applied to all JS/TS files/outputs

@louis-bompart louis-bompart requested a review from a team as a code owner September 3, 2024 18:45
@louis-bompart louis-bompart requested review from olamothe, fpbrault and alexprudhomme and removed request for a team September 3, 2024 18:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ❌ 1 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 8 packages with OpenSSF Scorecard issues.

View full job summary

@louis-bompart louis-bompart changed the title fix/JSUI 3531 fix: add patch-package to prd dep, enhance modal-box patch Sep 3, 2024
@louis-bompart louis-bompart merged commit cde34a3 into master Sep 10, 2024
3 of 4 checks passed
@louis-bompart louis-bompart deleted the fix/JSUI-3531 branch September 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe olamothe approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louis-bompart @olamothe @y-lakhdar @alexprudhomme