Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Card importing ImageProps bug #364

Closed
wants to merge 1 commit into from

Conversation

RJSonnenberg
Copy link

Resolves issue #363 where ImageProps type was not being properly exported from the Image type file and imported in Card type file.

@kennethnym
Copy link
Collaborator

Thanks for your PRs. I will review them when I'm free.

@kennethnym kennethnym self-requested a review August 13, 2021 13:42
@kennethnym
Copy link
Collaborator

Hey @RJSonnenberg, sorry I have been quite busy for the past week. In #362 @petertodorov requested the ability to extend on built-in props which is not possible since Bulma component props are hidden from the user. I am planning to make a PR that makes the props public so that users can access them and extend on them, which will include exporting ImageProps. I will close this PR for now. #363 will be addressed by that PR as well.

@kennethnym kennethnym closed this Aug 13, 2021
@RJSonnenberg
Copy link
Author

Hey @RJSonnenberg, sorry I have been quite busy for the past week. In #362 @petertodorov requested the ability to extend on built-in props which is not possible since Bulma component props are hidden from the user. I am planning to make a PR that makes the props public so that users can access them and extend on them, which will include exporting ImageProps. I will close this PR for now. #363 will be addressed by that PR as well.

@kennethnym Any progress on your PR?

@kennethnym
Copy link
Collaborator

Sorry, I'm pretty busy recently. I'll start working on it when I'm free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants