Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBL-6307: Database MMap Configuration API and tests #3333

Merged
merged 2 commits into from
Oct 18, 2024
Merged

CBL-6307: Database MMap Configuration API and tests #3333

merged 2 commits into from
Oct 18, 2024
+152 −8

Conversation

velicuvlad
Copy link
Contributor

@velicuvlad velicuvlad commented Oct 15, 2024 •
edited
Loading

Includes:

  • LiteCore 3.2.1-9.
  • both Obj-C and Swift impl and tests.
  • Defaults re-generated to include both fullSync and mmap.

@velicuvlad velicuvlad changed the title CBL-6307: Databaes MMap Configuration API and tests CBL-6307: Database MMap Configuration API and tests Oct 16, 2024
@velicuvlad velicuvlad requested a review from pasin October 16, 2024 17:28
@pasin pasin requested a review from bmeike October 16, 2024 22:47
pasin
pasin requested changes Oct 16, 2024
View reviewed changes
Objective-C/CBLDatabase.mm Outdated Show resolved Hide resolved
Objective-C/Tests/DatabaseTest.m Outdated Show resolved Hide resolved
bmeike
bmeike approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@velicuvlad velicuvlad force-pushed the CBL-6307 branch 2 times, most recently from eba2bd5 to 3939bc6 Compare October 17, 2024 18:06
@velicuvlad velicuvlad merged commit 8331d3d into release/3.2 Oct 18, 2024
15 checks passed
@velicuvlad velicuvlad deleted the CBL-6307 branch October 18, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeike bmeike bmeike approved these changes

@pasin pasin pasin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velicuvlad @bmeike @pasin