Skip to content

Commit

Permalink
Fix crash on Print panel (fix #1753, fix #1757)
Browse files Browse the repository at this point in the history
  • Loading branch information
1024jp committed Nov 13, 2024
1 parent 9d5f855 commit e21b8d5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
- [trivial] Omit commands in the Debug (ladybug) menu from the results of the Quick Action bar.


### Fixes

- Fix crashing when opening the Print dialog.



5.0.4 (684)
--------------------------
Expand Down
2 changes: 1 addition & 1 deletion Packages/MacUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ let package = Package(
.package(url: "https://github.com/SimplyDanny/SwiftLintPlugins", from: Version(0, 57, 0)),
],
targets: [
.target(name: "ControlUI", resources: [.process("Assets.xcassets")]),
.target(name: "ControlUI"),

.target(name: "RegexHighlighting", dependencies: ["EditorCore"]),
.testTarget(name: "RegexHighlightingTests", dependencies: ["RegexHighlighting"]),
Expand Down
2 changes: 1 addition & 1 deletion Packages/MacUI/Sources/ControlUI/FormPopUpButton.swift
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public final class FormPopUpButtonCell: NSPopUpButtonCell {
}

// draw chevron
let chevron = NSImage(symbolName: "chevronUpChevronDownNarrow", bundle: .module, variableValue: 0)!
let chevron = NSImage(resource: .chevronUpChevronDownNarrow)
let chevronColor: NSColor = switch (isHighContrast, self.isEnabled) {
case (false, true): .controlTextColor
case (false, false): .disabledControlTextColor
Expand Down

0 comments on commit e21b8d5

Please sign in to comment.