Skip to content

fix(number-field): match small size line height to its height - #911

Open
NessinM wants to merge 2 commits into
cosscom:mainfrom
NessinM:fix/number-field-size
Open

NessinM wants to merge 2 commits into
cosscom:mainfrom
NessinM:fix/number-field-size

Conversation

@NessinM

@NessinM NessinM commented Oct 22, 2026 •

Copy link
Copy Markdown

Summary

  • The small number field used the large size line-height (leading-8.5, 34px) from the sm breakpoint while the input height is h-6.5 (26px), so the value sat too low.
  • size="sm" now uses leading-6.5, in the component, the package copy, and the published registry JSON.

Test plan

  • Open the Number Field docs at a viewport wider than 640px
  • Confirm the small input is 26px tall and the value is vertically centered
  • Confirm the default and large sizes are unchanged
  • Increment and decrement the small field

NessinM and others added 2 commits October 22, 2026 10:49
The registry JSON still shipped leading-8.5 for the small input.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
coss-com-origin Skipped Skipped Oct 22, 2026 5:05pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – coss-com-origin October 22, 2026 17:05 Inactive
@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown

@NessinM is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@NessinM

NessinM commented Oct 26, 2026

Copy link
Copy Markdown
Author

Hey @pasqualevitiello, when you have a moment, could you take a look at this one? It's a small fix: the sm number field was using leading-8.5 (34px) on a 26px input, so the value sat too low. It now uses leading-6.5.

Also, since this PR comes from a fork, the Vercel deployments and 2 workflows are waiting for authorization from a maintainer. Could someone from the team approve them so the preview can run? Thanks!

This branch was previously deployed

1 inactive deployment
Preview – coss-com-origin — 773cc702 Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant