Bump image versions fix python-searchable demo #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G1gg1L3s
reviewed
Jul 1, 2024
Comment on lines
+621
to
+628
| # using commit instead of version/tag to use the commit with specific SqlAlchemy from examples/python | ||
| # https://github.com/cossacklabs/acra/pull/669/commits/be2ab1a4440e105dee1423ae21da1ee74e842801 | ||
| # and some examples/python fixes | ||
| # https://github.com/cossacklabs/acra/commit/e1773020a881a39d126724bd3992b9b436173fa0 | ||
| COSSACKLABS_ACRA_VCS_REF=${COSSACKLABS_ACRA_VCS_REF:-'e1773020a881a39d126724bd3992b9b436173fa0'} | ||
| if [ -d "${PROJECT_DIR}/acra" ] | ||
| then | ||
| git -C "${PROJECT_DIR}/acra" checkout "$COSSACKLABS_ACRA_VCS_BRANCH"; | ||
| git -C "${PROJECT_DIR}/acra" checkout "$COSSACKLABS_ACRA_VCS_REF"; |
There was a problem hiding this comment.
If I understand correctly, this commit is pinned because it was done after the 0.95.0 and we don't have a tag to refer to it, right?
There was a problem hiding this comment.
Exactly! Moreover there are no tag-based branches like 0.95.0 its only tags, so we should using come commits
There was a problem hiding this comment.
Ok, thanks! Could you then add a tag TODO or something to mark this as a temporal workaround?
G1gg1L3s
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.