Fix shameful bug in settings API (wrongly inheriting from base setting)

cosmoshsv · Jun 24, 2016 · bd1c3ea · bd1c3ea
1 parent 0493000
commit bd1c3ea
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/imagespace_cmu/server/settings.py b/imagespace_cmu/server/settings.py
@@ -1,6 +1,7 @@
 from girder.models.setting import Setting
+from girder.plugins.imagespace.settings import ImageSpaceSetting
 
-class CmuSetting(Setting):
+class CmuSetting(ImageSpaceSetting):
     requiredSettings = ('IMAGE_SPACE_CMU_PREFIX',
                         'IMAGE_SPACE_CMU_BACKGROUND_SEARCH',
                         'IMAGE_SPACE_CMU_FULL_IMAGE_SEARCH')

diff --git a/imagespace_columbia/server/settings.py b/imagespace_columbia/server/settings.py
@@ -1,6 +1,7 @@
 from girder.models.setting import Setting
+from girder.plugins.imagespace.settings import ImageSpaceSetting
 
-class ColumbiaSetting(Setting):
+class ColumbiaSetting(ImageSpaceSetting):
     requiredSettings = ('IMAGE_SPACE_COLUMBIA_INDEX',)
 
     def validateImageSpaceColumbiaIndex(self, doc):

diff --git a/imagespace_flann/server/settings.py b/imagespace_flann/server/settings.py
@@ -1,6 +1,7 @@
 from girder.models.setting import Setting
+from girder.plugins.imagespace.settings import ImageSpaceSetting
 
-class FlannSetting(Setting):
+class FlannSetting(ImageSpaceSetting):
     requiredSettings = ('IMAGE_SPACE_FLANN_INDEX',)
 
     def validateImageSpaceFlannIndex(self, doc):

diff --git a/imagespace_georgetown/server/settings.py b/imagespace_georgetown/server/settings.py
@@ -1,6 +1,7 @@
 from girder.models.setting import Setting
+from girder.plugins.imagespace.settings import ImageSpaceSetting
 
-class GeorgetownSetting(Setting):
+class GeorgetownSetting(ImageSpaceSetting):
     requiredSettings = ('IMAGE_SPACE_GEORGETOWN_DOMAIN_DYNAMICS_SEARCH',)
 
     def validateImageSpaceGeorgetownDomainDynamicsSearch(self, doc):