Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decouple IBCStore into a separate contract #76

Merged
merged 12 commits into from
Oct 30, 2024

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Oct 21, 2024

closes: #71

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (e120d31) to head (bbf070a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          12       12           
  Lines         337      337           
  Branches       11       11           
=======================================
  Hits          332      332           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lookgs good. I would be interested to also see updates to the benchmarks, if the cross-contract calls here have any significant impact on gas or not.

@srdtrk srdtrk merged commit 8254f92 into main Oct 30, 2024
11 checks passed
@srdtrk srdtrk deleted the serdar/xxx-decouple-store branch October 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor IBCStore into a separate contract
2 participants