Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switched to UUPS proxy pattern with admin management #247

Merged
merged 24 commits into from
Jan 30, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Jan 30, 2025

Description

closes: #232
closes: #223

This PR closes #223 by leaving it up to the deployer to implement timelocks (with some documentation)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (864be6d) to head (3452e66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   99.26%   99.29%   +0.02%     
==========================================
  Files          11       12       +1     
  Lines         543      566      +23     
==========================================
+ Hits          539      562      +23     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srdtrk srdtrk changed the title feat: switched to UUPS proxy pattern with custom admin management feat: switched to UUPS proxy pattern with admin management Jan 30, 2025
@srdtrk srdtrk marked this pull request as ready for review January 30, 2025 07:34
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this pattern! Great work here 🙏
I left some questions around the setup which would be good to get some alignement on, but this is looking really really good!

contracts/ICS20Transfer.sol Outdated Show resolved Hide resolved
contracts/ICS26Router.sol Outdated Show resolved Hide resolved
contracts/utils/IBCUUPSUpgradeable.sol Outdated Show resolved Hide resolved
contracts/ICS20Transfer.sol Show resolved Hide resolved
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! LGTM 🙌

@gjermundgaraba gjermundgaraba merged commit 0448c0c into main Jan 30, 2025
61 checks passed
@gjermundgaraba gjermundgaraba deleted the serdar/232-uups-2 branch January 30, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from transparent proxies to UUPS proxies Add timelocks to migrations and upgrades
2 participants