Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IBCStore into a separate contract #71

Closed
srdtrk opened this issue Oct 4, 2024 · 1 comment · Fixed by #76
Closed

Refactor IBCStore into a separate contract #71

srdtrk opened this issue Oct 4, 2024 · 1 comment · Fixed by #76
Labels
enhancement Improvements needs discussion This issue needs more discussion before its implementation

Comments

@srdtrk
Copy link
Member

srdtrk commented Oct 4, 2024

Description

Currently, the IBCStore is implemented as an abstract contract and used by ICS26Router, which results in all state being stored directly in the ICS26Router contract. To improve modularity and future-proof our design, we should decouple the IBCStore from the ICS26Router. This separation will not only enhance the clarity of responsibilities between the router and the storage layer, but it will also facilitate easier contract migrations and upgrades in the future (see issue #12).

@srdtrk srdtrk added enhancement Improvements needs discussion This issue needs more discussion before its implementation labels Oct 4, 2024
@sangier
Copy link
Contributor

sangier commented Oct 10, 2024

Hey guys, just seen that a new version of solidity "0.8.28" has been released and it introduces the "transient storage" concept which may be useful to save storage costs. Not really sure if this can be useful for this refactor, but it may be worth to check it out!

Ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements needs discussion This issue needs more discussion before its implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants