Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disables debug server by default #1496

Merged

Conversation

AntiTyping
Copy link
Contributor

@AntiTyping AntiTyping commented Sep 9, 2024

  1. Adds --enable-debug-server flag that defaults to false
  2. Displays warning message in logs if the debug server is enabled

image

@AntiTyping AntiTyping requested a review from a team as a code owner September 9, 2024 20:16
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me!

@jtieri jtieri merged commit baff835 into cosmos:main Sep 11, 2024
21 checks passed
@freak12techno
Copy link
Contributor

Just faced that not enabling it disabled Prometheus metrics, which I think is a must in production. Can we at least split these two? Seems uncool that now it forces you either to see a warning on using a debug server (and says you should not use it in production), or live without metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants