[sdk50] Lint the go relayer like IBC-go #3
faddatAnnotations
10 errors and 10 warnings
|
lint:
internal/relaydebug/debugserver.go#L50
Error return value of `srv.Serve` is not checked (errcheck)
|
|
lint:
cmd/chains_test.go#L77
Error return value of `enc.Encode` is not checked (errcheck)
|
|
lint:
relayer/chains/cosmos/log.go#L67
appendAssign: append result not assigned to the same slice (gocritic)
|
|
lint:
relayer/chains/penumbra/log.go#L59
appendAssign: append result not assigned to the same slice (gocritic)
|
|
lint:
cmd/feegrant.go#L53
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
lint:
cmd/root.go#L170
exitAfterDefer: os.Exit will exit, and `defer cancel()` will not run (gocritic)
|
|
lint:
internal/relaydebug/debugserver.go#L42
G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
|
|
lint:
cregistry/chain_info.go#L213
G107: Potential HTTP request made with variable url (gosec)
|
|
lint:
cregistry/cosmos_github_registry.go#L58
G107: Potential HTTP request made with variable url (gosec)
|
|
lint:
relayer/query_test.go#L137
`mockClientStateInfo` - `chainID` always receives `"test-chain-id"` (unparam)
|
|
lint:
relayer/codecs/ethermint/encoding.go#L347
redefines-builtin-id: redefinition of the built-in type any (revive)
|
|
lint:
relayer/chains/cosmos/tx.go#L357
import-shadowing: The name 'tx' shadows an import name (revive)
|
|
lint:
relayer/chains/cosmos/tx.go#L633
import-shadowing: The name 'tx' shadows an import name (revive)
|
|
lint:
relayer/chains/cosmos/query.go#L50
import-shadowing: The name 'query' shadows an import name (revive)
|
|
lint:
relayer/chains/cosmos/cosmos_chain_processor.go#L61
import-shadowing: The name 'provider' shadows an import name (revive)
|
|
lint:
relayer/chains/cosmos/msg.go#L32
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
lint:
relayer/chains/cosmos/msg.go#L43
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
lint:
relayer/chains/cosmos/feegrant.go#L304
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint:
relayer/chains/cosmos/tx.go#L166
context-as-argument: context.Context should be the first parameter of a function (revive)
|
|
lint:
relayer/chains/cosmos/tx.go#L361
context-as-argument: context.Context should be the first parameter of a function (revive)
|