Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove democracy/governance whitelisting #2381

Merged
merged 10 commits into from
Nov 7, 2024
Merged

refactor!: remove democracy/governance whitelisting #2381

merged 10 commits into from
Nov 7, 2024

Conversation

stana-miric
Copy link
Collaborator

Implements #1194

@stana-miric stana-miric self-assigned this Nov 4, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/democracy Assigned automatically by the PR labeler labels Nov 4, 2024
@github-actions github-actions bot added C:Build Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler labels Nov 4, 2024
@stana-miric stana-miric changed the title feat: remove democracy/governance whitelisting refactor! remove democracy/governance whitelisting Nov 4, 2024
@stana-miric stana-miric changed the title refactor! remove democracy/governance whitelisting refactor!: remove democracy/governance whitelisting Nov 4, 2024
@stana-miric stana-miric marked this pull request as ready for review November 4, 2024 15:06
@stana-miric stana-miric requested a review from a team as a code owner November 4, 2024 15:06
MSalopek
MSalopek approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Seems we could also keep the gov code as an example for restricting proposals that can be voted on. But then again, there's not much value in keeping it.

Thanks!

mpoke
mpoke approved these changes Nov 5, 2024
View reviewed changes
docs/docs/build/modules/04-democracy.md Outdated Show resolved Hide resolved
docs/docs/consumer-development/consumer-chain-governance.md Outdated Show resolved Hide resolved
@mpoke mpoke added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 6, 2024
@mpoke mpoke merged commit 22f72bd into main Nov 7, 2024
16 of 19 checks passed
@mpoke mpoke deleted the smiric/remove-gov-whitelisting branch November 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@mpoke mpoke mpoke approved these changes

Assignees

@stana-miric stana-miric

Labels
C:Build Assigned automatically by the PR labeler C:Docs Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/democracy Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stana-miric @mpoke @MSalopek