Skip to content

feat(pfm): add custom error for forward transfer failures #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

feat(pfm): add custom error for forward transfer failures #8702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137c9e7
Update errors.go
CreeptoGengar Nov 7, 2025
7cd8402
Update keeper.go
CreeptoGengar Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/apps/packet-forward-middleware/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,7 @@ func (k *Keeper) ForwardTransferPacket(ctx sdk.Context, inFlightPacket *types.In
"denom", token.Denom,
"error", err,
)
// TODO: Should probably have custom errors!
return errorsmod.Wrap(sdkerrors.ErrInsufficientFunds, err.Error())
return errorsmod.Wrap(types.ErrForwardTransferFailed, err.Error())
}

// Store the following information in keeper:
Expand Down
1 change: 1 addition & 0 deletions modules/apps/packet-forward-middleware/types/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ import (
var (
ErrMetadataKeyNotFound = errorsmod.Register(ModuleName, 1, "metadata key not found in packet data")
ErrInvalidForwardMetadata = errorsmod.Register(ModuleName, 2, "invalid forward metadata")
ErrForwardTransferFailed = errorsmod.Register(ModuleName, 3, "failed to forward transfer packet")
)