fix: persist code+account before DeleteAccount can verify#921
Open
mmsqe wants to merge 5 commits intocosmos:mainfrom
Open
fix: persist code+account before DeleteAccount can verify#921mmsqe wants to merge 5 commits intocosmos:mainfrom
mmsqe wants to merge 5 commits intocosmos:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 65.49% 65.50%
=======================================
Files 318 318
Lines 22222 22226 +4
=======================================
+ Hits 14555 14559 +4
Misses 6502 6502
Partials 1165 1165
🚀 New features to boost your workflow:
|
aljo242
reviewed
Jan 6, 2026
| if obj.selfDestructed { | ||
| // For EIP-6780 same-tx self-destruct: persist code+account first so DeleteAccount's | ||
| // IsContract check can verify it, then immediately delete everything | ||
| if obj.code != nil && obj.dirtyCode && len(obj.code) > 0 { |
aljo242
reviewed
Jan 6, 2026
| } | ||
| } | ||
|
|
||
| func (suite *StateDBTestSuite) TestEIP6780SameTxCodePersistence() { |
Contributor
There was a problem hiding this comment.
can we test the error cases here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
align selfdestruct behavior as go-ethereum
Closes: #905
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch