Skip to content

fix: inconsistent chain id in rpc backend #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 16, 2025

unify backend.EvmChainId and backend.ChainConfig().ChainID

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

yihuang and others added 2 commits July 16, 2025 18:12
unify `backend.EvmChainId` and `backend.ChainConfig().ChainID`
@aljo242
Copy link
Contributor

aljo242 commented Jul 16, 2025

@yihuang we will merge this - but in the future we will require signed commits on this repo

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@yihuang
Copy link
Contributor Author

yihuang commented Jul 16, 2025

@yihuang we will merge this - but in the future we will require signed commits on this repo

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

for this one, it seems tricker than I thought, currently the tests don't all pass, and things are quite confusing to me.

@aljo242
Copy link
Contributor

aljo242 commented Jul 16, 2025

Looks like they have to do with mock testing. It might just be that the type being passed has changed in your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants