feat: add limit for batch request and response size #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladjdk
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Lgtm, thank you for the contribution.
Similar to other PRs, could you add a more thorough description here and in the issue of the problem and your solution? The reference was helpful for context, but the PR you referenced is different from the changes you made here.
mmsqe
changed the title
vladjdk
requested changes
Jul 4, 2025
rpc/backend/call_tx.go
Outdated
| @@ -369,10 +369,6 @@ func (b *Backend) DoCall( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| length := len(res.Ret) | |||
There was a problem hiding this comment.
I think you removed this by mistake in the latest commits :)
There was a problem hiding this comment.
revert the space, no change for this file
There was a problem hiding this comment.
Ahh, I see, the restriction is now happening on the geth side. Lgtm!
rpc/backend/call_tx.go
Outdated
| @@ -369,7 +369,6 @@ func (b *Backend) DoCall( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
vladjdk
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
batch-request-limitconfig to enforces the maximum number of requests per batch and prevents abuse by oversized batch requestsbatch-response-max-sizeconfig to allow server should reject the batch or truncate the response, returning an error or partial result indicating the response size limit was exceeded.Closes: #241, for test info
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md