-
Couldn't load subscription status.
- Fork 405
replace jasmine with vitest #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
886315e to
25f8e03
Compare
4382591 to
9165c6b
Compare
|
Why is there a cosmjs/.github/workflows/test.yml Line 103 in 8fb7421
Line 154 in 31db121
Is there another way to do whatever it is it's doing? Edit: #1850 |
c450087 to
8c5bf0a
Compare
This advertises the minimum node version in the shields.io badge.
In a local test it took 9.8s to complete.
Even given the comment, 1s might be excessively large.
"process them later" test and "broken off" test
It took about 7.5s in testing. It seems slower in Vitest than Jasmine oddly, the server side delay is only 5s.
and use the same filename as all other packages use, testutils with an S for consistency.
And here's no testdata/ directory in this package, only in cosmwasm-stargate, so delete that glob.
189d01f to
a55d9a3
Compare
e955ff2 to
5a8c47a
Compare
Vitest has decent defaults so a configuration file may not even be required.
Blocked on:
#1809 & #1832 & #1833 #1004
Converting is easy now that
xitis in use:And
--quietis passed by the coverage script, so that has to be removed when replacing the Jasmine CJS file.cosmjs/packages/utils/jasmine-testrunner.cjs
Line 29 in ca243f5
cosmjs/packages/utils/package.json
Line 35 in ca243f5
The default timeout in Vitest is 5s but some tests need longer than that. The slow server tests have a 5s server-side delay, so:
sockettests that spawn child processes withexec()are heavily entangled with the others. If one test times out, it causes completely unrelated tests to fail. And they can't be run in parallel (Vitest has per-spec-file parallelism by default).cosmjs/packages/socket/src/reconnectingsocket.spec.ts
Lines 206 to 209 in ca243f5