Add a format parameter to the Decimal type

[saggi-dw]

A user on DokuWiki Forum need a special format for numbers.
https://forum.dokuwiki.org/d/22218-how-to-force-leading-zeroes-when-using-a-bureacuracy-form-with-struct

This add a new config parameter for the Decimal type: format

If format is set and valid all other formatting parameters(roundto, decpoint, thousands, trimzeros, engineering) are ignored.
format must be a valid format for sprintf and accepts the following number formats: bdeEfFu

[splitbrain]

LGTM. Can you fix the code sniffer issue and squash your commits?

[saggi-dw]

I hope that was all correct. My first question: What is squashing? 🙈
I think it worked.

[splitbrain]

Great. One more thing: can you please extend the unit tests to cover your new setting? See https://github.com/cosmocode/dokuwiki-plugin-struct/blob/master/_test/types/DecimalTest.php

[saggi-dw]

OK, test failed:
There was 1 failure:

1) dokuwiki\plugin\struct\test\types\DecimalTest::test_renderValue with data set #43 ('1', '1 ', '-1', '.', ' ', true, '', '', false, '%u')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1 '
+'1'

I will fix that.

[saggi-dw]

The commit message is now total crap. Unfortunately, I have no idea whether it can still be changed...

[splitbrain]

The commit message is now total crap. Unfortunately, I have no idea whether it can still be changed...

You can do a git commit --amend it lets you edit the last commit. Once done, do another force push.

[splitbrain]

can you also add tests for where the format string is wrong and thus ignored?

[saggi-dw]

You are right. The - should be in the regex as a character and not as a range. By extending the test I realized that. Thank you!

[splitbrain]

This last test looks interesting. I think it is dependent on the platform and would fail on a 32bit system

[saggi-dw]

Of course you're right again!
32bit:

php > printf('%u','-1');
4294967295

I will remove the last line of the test and adjust the penultimate one. It should only be checked whether %u is recognized.