Fix compatibility issues with recent Emacs versions #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: In toplevel form: helm-rg.el:672:12: Error: custom-declare-variable ‘helm-rg-default-directory’ docstring has wrong usage of unescaped single quotes (use \=' or different quoting such as `...')
Resolves: In toplevel form: helm-rg.el:1072:6: Error: ‘helm-attrset’ is an obsolete function (as of 3.7.0); use ‘helm-set-attr’ instead.
Resolves: In toplevel form: tests/helm-rg-test.el:66:38: Error: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues when attempting to run the interactive tests on Emacs 30.1. See the commits for details.
This does mean that the package likely won't work in Emacs <29.1, or with older versions of Helm. I tested it with Emacs 30.1 and Helm 20250716.528 (03dd33339cf9, helm-core 4.0.4).
Considering this package is not maintained, I don't expect this to be merged, but maybe it will be useful for future maintainers.