Repository navigation
fix(omp): resolve host modules and tokenizer from plugin runtime - #655
Conversation
|
Design gate skipped: the |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Thanks for this, and for splitting it from the discovery change. Before review, please address the open bot finding. Greptile notes that the new tokenizer-roots test may not exercise the fallback: Once the finding is resolved, we'll take it through review. |
|
Addressed all three threads in 3b046f4. The runtime fixture forces the primary loader to fail under bun --no-install and proves fallback estimator identity. A second fixture proves the plugin dependency beats a conflicting host-wide copy. Three focused tests, plugin typecheck, and Pi build passed. Negative control with the old probe ordering fails the precedence regression. Refs #657 for maintainer design approval. |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
|
Thanks for resolving the findings. I've labelled this
Affected: "the fallback loads from the plugin tree when the primary loader fails" and "the plugin's own tree outranks the host-wide ~/.omp/plugins copy". Could you rebase onto master and have the fixture copy |
3b046f4 to
49f86b5
Compare
|
Rebased onto upstream master e3d82fa and pushed 49f86b5. The isolated tokenizer fixture now traverses and copies the recursive relative runtime import closure using Bun.Transpiler.scanImports, including token-count-exact.ts, instead of a fixed shared directory. Bare package dependencies remain excluded so the primary tokenizer loader still fails as intended. Both affected tests and the probe-roots test pass (3/3). Plugin typecheck, focused Biome check, and plugin build also pass. |
|
Merged, thank you. It passed the full plugin, Pi and CLI suites on current master, and it ships in the next release. Issue 657 stays open until then. |
Refs #657
Fix compiled OMP host-module imports and tokenizer runtime fallback resolution. Preserve package-local tokenizer precedence.
Independent of PR #656. Initial standalone verification: typecheck, build, 29 focused tests. Review regression improvements are in progress.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues remain.Summary
This PR keeps Pi and OMP host imports visible to the host loader and adds tokenizer fallback roots for the plugin’s install tree and OMP’s plugin directory.
Reviews (3) · Last reviewed commit: "test(tokenizer): copy recursive relative..." · Reviewed by Greptile