Skip to content

Correctly allocate a Gib #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

janisozaur
Copy link
Contributor

Similar to #186, but I fear I'm missing something here and wanted to submit this as a separate PR for better review.

Fixed issues found by PVS-Studio

Copy link
Contributor

@HeliumAnt HeliumAnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be correct, since the editor simply crashes on save atm. Seems to have been broken in #160

@janisozaur
Copy link
Contributor Author

Thanks for the review. Can you merge it?

@HeliumAnt
Copy link
Contributor

HeliumAnt commented Feb 17, 2025

No, I think only Causless can

@Causeless Causeless added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 19, 2025
@Causeless Causeless added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 20, 2025
@Causeless Causeless added this pull request to the merge queue Feb 20, 2025
Merged via the queue into cortex-command-community:development with commit 4c5c4eb Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants