Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux and MacOS backtrace #174

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Linux and MacOS backtrace #174

wants to merge 3 commits into from

Conversation

HeliumAnt
Copy link
Contributor

Adds pretty printed backtrace and signal handler for non windows systems using bombela/backward-cpp
(This could also do stacktrace on windows)

@HeliumAnt HeliumAnt requested a review from Causeless December 20, 2024 11:27
Causeless
Causeless requested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@Causeless Causeless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we do this for Windows too? I'd rather avoid having two stack trace libs

@HeliumAnt
Copy link
Contributor Author

HeliumAnt commented Jan 12, 2025 •
edited
Loading

Should pretty print backtrace on win as well now. (Pls test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Causeless Causeless Causeless requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeliumAnt @Causeless