Skip to content

Attachables: Radius Effect #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Bit-Crust
Copy link
Contributor

@Bit-Crust Bit-Crust commented Nov 18, 2024

Decorative, illustrative, or physically minute attachments, such as hair, wounds, or flashes, can currently affect parent radius (in absence of hardcoded special cases), which is taken to be both visual and physical, so that an actor will crouch unnecessarily if something were to drag behind it or far away, or if a flash were to be emitted from something other than the barrel of a HDFirearm.

  • This can be partially solved by allowing an attachable to opt out, using m_AffectsRadius, which is included.
  • The diameter is also needed to determine which intermediate bitmap to use while settling the MOSR, however, so there has to be a metric of the largest bounding diameter, maybe m_BoundingDiameter.
  • This also means there are two different radii to update with MOSRotating::HandlePotentialRadiusAffectingAttachable, so the function will have to be modified to update both accurately without wasting computation.
  • Considering a property for if a non-radius affecting attachable's own attachables should be able to affect the radius of it's parent. I don't remember why I was considering this.
  • With this change, flashes and wounds and such could be changed to just include AffectsRadius = 0.
  • With all flashes and wounds marked as such whereever, a couple C++ checks are genericized and can be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants