This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
FMOD and sound improvements - busses and effects and properties #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawnishoovy
added
enhancement
Causeless
reviewed
Nov 4, 2023
Causeless
approved these changes
Nov 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of all the confusing initial busses and replaces them with this hierarchy:
Master
-SFX
-UI
-Music
Sound volume controls SFX and UI, Music volume controls Music. We might want a UI slider or we might not, whatever, it's not in here.
Master has a safety volume limiter added.
SFX has a cool, heavy-handed compression effect added. Can be changed later in a later PR to add proper ducking and sidechaining.
SoundContainers route to SFX by default, but can be changed using BusRouting property.
PanningStrengthMultiplier added, does what it says on the tin, can eventually be used for some ambient effects (or whatever other funky stuff.)
Since the weird Immobile sound bus was removed, the 3D effect processing code now checks for FMOD_2D mode and skips updating positional stuff in that case. May theoretically be the tiniest bit slower, but I doubt it'll ever matter.