Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ninja Multi-Config Cross-Config support #492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jschwe
Copy link
Collaborator

@jschwe jschwe commented Mar 6, 2024

The default output directory was the same for all $<CONFIG>s, which caused conflicting build rules.

The issue probably still exists for the rare case when:

  1. The user specified an OUTPUT_DIRECTORY property AND
  2. did not specify an OUTPUT_DIRECTORY_$<CONFIG> property AND
  3. The value of the OUTPUT_DIRECTORY does not contain a genex,
      depending on the $<CONFIG>.

Corrosion could detect and append a $<CONFIG> in this case, but
I think leaving this up to the user is reasonable for now.

The default output directory was the same for all `$<CONFIG>`s,
which caused conflicting build rules.
The issue probably still exists for the rare case when:
1. The user specified an `OUTPUT_DIRECTORY` property AND
2. did not specify an `OUTPUT_DIRECTORY_$<CONFIG>` property AND
3. The value of the `OUTPUT_DIRECTORY` does not contain a genex,
  depending on the `$<CONFIG>`.

Corrosion could detect and append a `$<CONFIG>` in this case, but
I think leaving this up to the user is reasonable for now.
Add a test with CMAKE_CROSS_CONFIGS set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant