Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #Issue-191 UI Compatibility #192

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

vishisht-dubey
Copy link
Contributor

Hii @skks1212 please look into this pr and let me know if there is any issue

Copy link

vercel bot commented Mar 13, 2024

@vishisht-dubey is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@vishisht-dubey
Copy link
Contributor Author

Hii @skks1212 please review this pr and let me know

src/utils/constants.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@vishisht-dubey
Copy link
Contributor Author

Hii @skks1212 i have done the changes please review the pr

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ayushma-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:55pm

@skks1212
Copy link
Member

@vishisht-dubey can you attach screenshots of what all UI changes have been carried out in this PR?

@vishisht-dubey
Copy link
Contributor Author

@vishisht-dubey can you attach screenshots of what all UI changes have been carried out in this PR?

one is this
Screenshot 2024-03-09 194118
other is introduction of theme change button in admin sidebar
Screenshot 2024-03-15 182407
another is this slider was not visible in light mode
Screenshot 2024-03-15 182834
apart from it some other places where bg is hardcoded and properly not displaying.

@vishisht-dubey
Copy link
Contributor Author

@skks1212 any update?

@vishisht-dubey
Copy link
Contributor Author

Hii @skks1212 would you please review this so that we can close this issue. Thanks

@skks1212
Copy link
Member

@vishisht-dubey
image
There is a white border on inputs. It should be border-secondary
image
Why is the logo dark here? Checkout implementation for main sidebar.
image
Why blue and white? Use green and secondary colors here

Copy link
Member

@skks1212 skks1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make changes as per above comment

@vishisht-dubey
Copy link
Contributor Author

@skks1212 can i have link of NEXT_PUBLIC_LOGO_URL and NEXT_PUBLIC_LOGO_DARK_URL??

@skks1212
Copy link
Member

@vishisht-dubey NEXT_PUBLIC_LOGO_DARK_URL refers to /logo_white.svg and NEXT_PUBLIC_LOGO_URL refers to /logo_text.svg

@skks1212
Copy link
Member

skks1212 commented Mar 21, 2024

<img
                  src={(storage.theme || storage.preferedTheme) === 0 ? (process.env.NEXT_PUBLIC_LOGO_URL || "/logo_text.svg") : (process.env.NEXT_PUBLIC_LOGO_DARK_URL || "/logo_white.svg")}
                  alt="Logo"
                  className="w-full h-full object-contain"
                />

snippet from chat sidebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants